linux-kernel - Re: [PATCH v2] mm: vmscan: add VM_BUG_ON on illegal return values from scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <519B2224.50105@parallels.com>
Date:	Tue, 21 May 2013 11:28:36 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Pekka Enberg <penberg@...nel.org>
CC:	Oskar Andero <oskar.andero@...ymobile.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Radovan Lekanovic <radovan.lekanovic@...ymobile.com>,
	David Rientjes <rientjes@...gle.com>,
	Glauber Costa <glommer@...nvz.org>,
	Dave Chinner <dchinner@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Hugh Dickins" <hughd@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] mm: vmscan: add VM_BUG_ON on illegal return values
 from scan_objects

On 05/21/2013 11:17 AM, Pekka Enberg wrote:
> It seems to me relaxing the shrinker API restrictions and changing the
> "ret == -1" to "ret < 0" would be a much more robust approach...

Dave had already spoken against it, and I agree with him
Anybody returning any negative value different than -1 is definitely
doing something strange


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/