linux-kernel - Re: [PATCH 00/19] driver:usb&net: add missing platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519B2993.4090409@cn.fujitsu.com>
Date:	Tue, 21 May 2013 16:00:19 +0800
From:	Gu Zheng <guz.fnst@...fujitsu.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
CC:	David Miller <davem@...emloft.net>, libo.chen@...wei.com,
	gregkh@...uxfoundation.org, samuel@...tiz.org,
	stern@...land.harvard.edu, khc@...waw.pl,
	akpm@...ux-foundation.org, balbi@...com,
	sarah.a.sharp@...ux.intel.com, alexander.shishkin@...ux.intel.com,
	brudley@...adcom.com, linux-usb@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	lizefan@...wei.com
Subject: Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

On 05/21/2013 02:41 PM, Thomas Petazzoni wrote:

> Dear David Miller,
> 
> On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote:
>> From: Libo Chen <libo.chen@...wei.com>
>> Date: Tue, 21 May 2013 10:42:00 +0800
>>
>>> I find a lot of mistakes using struct platform_driver without owner.
>>> So I pick up some of them including usb and net modules
>>
>> Instead of doing it this way, which is obviously error prone and
>> easy to forget, make platform_driver_register() be a macro which
>> sets the module owner field then calls the real
>> __platform_driver_register().
> 
> Or, maybe make the existing module_platform_driver() macro do this?


But not all the modules use module_platform_driver() macro to replace the module init/exit.

Thanks,
Gu

> 
> Best regards,
> 
> Thomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/