linux-kernel - Re: [PATCH 2/5] perf: Reorder parameters of strglobmatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130521091947.GD10541@ghostprotocols.net>
Date:	Tue, 21 May 2013 11:19:47 +0200
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
	David Ahern <dsahern@...il.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Irina Tirdea <irina.tirdea@...el.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	yrl.pp-manager.tt@...achi.com, Oleg Nesterov <oleg@...hat.com>,
	Pekka Enberg <penberg@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Tom Zanussi <tom.zanussi@...el.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Borislav Petkov <bp@...e.de>, Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 2/5] perf: Reorder parameters of strglobmatch

Em Fri, May 17, 2013 at 11:21:11AM +0900, Masami Hiramatsu escreveu:
> (2013/05/16 23:55), Steven Rostedt wrote:
> > I'm a bit confused to the rational here. Can you explain in more detail
> > to why this patch is actually needed?
 
> Yes, actually, this patch is not needed from the viewpoint of execution,
> but less misuse for future use of the strglobmatch, I think.
 
> For example, glob(3) has the pattern parameter as the first one,
> 
>        int glob(const char *pattern, int flags,
>                 int (*errfunc) (const char *epath, int eerrno),
>                 glob_t *pglob);
 
> regexec(3) also has the compiled regexp at the first parameter,
 
>        int regexec(const regex_t *preg, const char *string, size_t nmatch,
>                    regmatch_t pmatch[], int eflags);
 
> Thus, I think a new user of strglobmatch() may guess that the first
> parameter should be the glob pattern.
 
> So, this patch is not technically needed, but from the viewpoint of coding
> naturally, it should be changed, IMHO.

So I suggest you state this in the changeset comment :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/