linux-kernel - Re: [PATCH] Finally eradicate CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130521101349.30660.qmail@stuge.se>
Date:	Tue, 21 May 2013 12:13:49 +0200
From:	Peter Stuge <peter@...ge.se>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-arch@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>, linux-pm@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-pcmcia@...ts.infradead.org,
	LKML <linux-kernel@...r.kernel.org>, cluster-devel@...hat.com,
	linux-mm@...ck.org, Hans Verkuil <hans.verkuil@...co.com>,
	Pavel Machek <pavel@....cz>,
	Doug Thompson <dougthompson@...ssion.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Steven Whitehouse <swhiteho@...hat.com>,
	linux-arm-kernel@...ts.infradead.org, linux-edac@...r.kernel.org
Subject: Re: [PATCH] Finally eradicate CONFIG_HOTPLUG

Are you changing the code to have HOTPLUG always -on- or -off- ?

From the commit message I had expected always -on-.


Stephen Rothwell wrote:
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -68,14 +68,6 @@
>   * are handled as text/data or they can be discarded (which
>   * often happens at runtime)
>   */
> -#ifdef CONFIG_HOTPLUG
> -#define DEV_KEEP(sec)    *(.dev##sec)
> -#define DEV_DISCARD(sec)
> -#else
> -#define DEV_KEEP(sec)
> -#define DEV_DISCARD(sec) *(.dev##sec)
> -#endif
> -
>  #ifdef CONFIG_HOTPLUG_CPU
>  #define CPU_KEEP(sec)    *(.cpu##sec)
>  #define CPU_DISCARD(sec)
> @@ -182,8 +174,6 @@
>  	*(.data)							\
>  	*(.ref.data)							\
>  	*(.data..shared_aligned) /* percpu related */			\
> -	DEV_KEEP(init.data)						\
> -	DEV_KEEP(exit.data)						\
..
> @@ -503,7 +489,6 @@
>  /* init and exit section handling */
>  #define INIT_DATA							\
>  	*(.init.data)							\
> -	DEV_DISCARD(init.data)						\

Shouldn't the effect of one of the above remain?


//Peter

Content of type "application/pgp-signature" skipped