linux-kernel - Re: [PATCH 1/1] Staging: bcm: Fix of various code style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3li79arar.fsf@redhat.com>
Date:	Tue, 21 May 2013 06:30:04 +0200
From:	Nikola Pajkovsky <npajkovs@...hat.com>
To:	Severin Gsponer <svgsponer@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kevin McKinney <klmckinney1@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Staging: bcm: Fix of various code style issues.

Severin Gsponer <svgsponer@...il.com> writes:

> Changed comment style to C89 in Version.h
> Fixed some whitespace issues in Typedefs.h
> Changed comment style to C89 in vendorspecificextn.c
> All issues found with checkpatch.pl
>
> Signed-off-by: Severin Gsponer <svgsponer@...il.com>
> ---
>  drivers/staging/bcm/Typedefs.h           |   22 ++--
>  drivers/staging/bcm/Version.h            |    8 +-
>  drivers/staging/bcm/vendorspecificextn.c |  197 +++++++++++++++---------------
>  3 files changed, 110 insertions(+), 117 deletions(-)
>
> diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h
> index a985abf..3dea509 100644
> --- a/drivers/staging/bcm/Typedefs.h
> +++ b/drivers/staging/bcm/Typedefs.h
> @@ -25,16 +25,16 @@ typedef unsigned int B_UINT32;
>  typedef unsigned long ULONG;
>  typedef unsigned long DWORD;
>  
> -typedef char* PCHAR;
> -typedef short* PSHORT;
> -typedef int* PINT;
> -typedef long* PLONG;
> -typedef void* PVOID;
> -
> -typedef unsigned char* PUCHAR;
> -typedef unsigned short* PUSHORT;
> -typedef unsigned int* PUINT;
> -typedef unsigned long* PULONG;
> +typedef char *PCHAR;
> +typedef short *PSHORT;
> +typedef int *PINT;
> +typedef long *PLONG;
> +typedef void *PVOID;
> +
> +typedef unsigned char *PUCHAR;
> +typedef unsigned short *PUSHORT;
> +typedef unsigned int *PUINT;
> +typedef unsigned long *PULONG;
>  typedef unsigned long long ULONG64;
>  typedef unsigned long long LARGE_INTEGER;
>  typedef unsigned int UINT32;
> @@ -43,5 +43,5 @@ typedef unsigned int UINT32;
>  #endif

I bet, there is no reason for such typedef's

-- 
Nikola
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/