linux-kernel - Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1369150371.18338.4.camel@lorien>
Date:	Tue, 21 May 2013 15:32:51 +0000
From:	Shuah Khan <shuah.kh@...sung.com>
To:	Gustavo Padovan <gustavo@...ovan.org>
CC:	"marcel@...tmann.org" <marcel@...tmann.org>,
	"johan.hedberg@...il.com" <johan.hedberg@...il.com>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"shuahkhan@...il.com" <shuahkhan@...il.com>
Subject: Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops

On Tue, 2013-05-21 at 00:28 -0300, Gustavo Padovan wrote:
> Hi Shuan,
> 
> * Shuah Khan <shuah.kh@...sung.com> [2013-05-21 01:02:58 +0000]:
> 
> > Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> > following message after power management device test. This change sets
> > reset_resume to btusb_resume().
> > 
> > [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> > [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
> > 
> > Signed-off-by: Shuah Khan <shuah.kh@...sung.com>
> > ---
> >  drivers/bluetooth/btusb.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 7a7e5f8..1eb90c0 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -1616,6 +1616,7 @@ static struct usb_driver btusb_driver = {
> >  #ifdef CONFIG_PM
> >  	.suspend	= btusb_suspend,
> >  	.resume		= btusb_resume,
> > +	.reset_resume	= btusb_resume,
> >  #endif
> >  	.id_table	= btusb_table,
> >  	.supports_autosuspend = 1,
> 
> Patch still doesn't apply, are you sending it with git-send-email?
> 
> Applying: Bluetooth: Add missing reset_resume dev_pm_ops
> /home/padovan/p/linux-trees/bluetooth-next/.git/rebase-apply/patch:13: trailing whitespace.
>         .reset_resume   = btusb_resume,
> error: patch failed: drivers/bluetooth/btusb.c:1616
> error: drivers/bluetooth/btusb.c: patch does not apply
> Patch failed at 0001 Bluetooth: Add missing reset_resume dev_pm_ops
> 
> 	Gustavo

I saved the patch from the email I sent and applied to your latest git
and it applies. I am not sure what happened. In any case, I just resent
it using git-send-email. Hope that works.

-- Shuah

Shuah Khan, Linux Kernel Developer - Open Source Group 
Samsung Research America (Silicon Valley)
shuah.kh@...sung.com | (970) 672-0658