linux-kernel - Re: [RFC PATCH] kmod: add ability to swap root in usermode helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130521162925.GA19785@redhat.com>
Date:	Tue, 21 May 2013 18:29:25 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Stanislav Kinsbursky <skinsbursky@...allels.com>,
	akpm@...ux-foundation.org, jlayton@...hat.com,
	lucas.demarchi@...fusion.mobi, rusty@...tcorp.com.au,
	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	bharrosh@...asas.com, devel@...nvz.org
Subject: Re: [RFC PATCH] kmod: add ability to swap root in usermode helper

On 05/21, J. Bruce Fields wrote:
>
> On Tue, May 21, 2013 at 05:28:36PM +0200, Oleg Nesterov wrote:
> >
> > OK, so do not do this. Export the new helper.
>
> You mean, export umh_set_fs_root() in the above?
>
> That might be OK.

Yes, or even call_usermodehelper_root().

I didn't argue with the new helper that, yes, has the additional
argument. Although personally I think it would be better to not
add it into kmod.c (until it has more users), but I am not sure
there is a better place somewhere in nfs code. Whatever is more
convenient for you.

To me this looks like call_usermodehelper_keys().

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/