linux-kernel - Re: [PATCH V2 1/2] ARM: mmc: bcm281xx SDHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201305212023.03272.arnd@arndb.de>
Date:	Tue, 21 May 2013 20:23:03 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	"Christian Daudt" <csd@...adcom.com>
Cc:	"Grant Likely" <grant.likely@...retlab.ca>,
	"Rob Herring" <rob.herring@...xeda.com>,
	"Rob Landley" <rob@...dley.net>,
	"Russell King" <linux@....linux.org.uk>,
	"Chris Ball" <cjb@...top.org>,
	"Stephen Warren" <swarren@...dia.com>,
	"Olof Johansson" <olof@...om.net>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Wei WANG" <wei_wang@...lsil.com.cn>,
	"Ludovic Desroches" <ludovic.desroches@...el.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mmc@...r.kernel.org, csd_b@...dt.org
Subject: Re: [PATCH V2 1/2] ARM: mmc: bcm281xx SDHCI driver

On Tuesday 21 May 2013, Christian Daudt wrote:
> >> +    cfg = devm_kzalloc(&pdev->dev, sizeof(*cfg), GFP_KERNEL);
> >> +    if (!cfg) {
> >> +            dev_err(&pdev->dev, "Can't allocate platform cfg\n");
> >> +            return NULL;
> >> +    }
> > Not needed
> what is not needed ?

The allocation, it can be part of the sdhci_pltfm_host data.

> >> +    const struct sdhci_pltfm_data *plat_data;
> > make it global.
> why make this global ?

Sorry for being unclear. I mean you can just use &sdhci_pltfm_data_kona
in the probe function, since the data is constant anyway, no need to have
a local variable for pulling this out of the device id.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/