linux-kernel - Re: [GIT PULL v2] MFD: Fixes due for the v3.10 -rc:s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130521215806.GC4566@zurbaran>
Date:	Tue, 21 May 2013 23:58:06 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Lee Jones <lee.jones@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Arnd Bergmann <arnd@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>, arnd@...db.de,
	Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [GIT PULL v2] MFD: Fixes due for the v3.10 -rc:s

Hi Fabio,

On Tue, May 21, 2013 at 11:12:30AM +0200, Fabio Baltieri wrote:
> On Tue, May 21, 2013 at 10:56:50AM +0200, Samuel Ortiz wrote:
> > On Fri, May 17, 2013 at 09:51:40AM +0200, Fabio Baltieri wrote:
> > > Hello Samuel,
> > > 
> > > On Fri, May 17, 2013 at 12:43:37AM +0200, Samuel Ortiz wrote:
> > > > > Fabio Baltieri (5):
> > > > >       mfd: abx500-core: Fix sparse warning
> > > > >       mfd: ab8500-sysctrl: Fix sparse warning
> > > > >       mfd: ab8500-sysctrl: Set sysctrl_dev during probe
> > > > >       mfd: ab8500-sysctrl: Let sysctrl driver work without pdata
> > > > Unless I'm missing something here, this one is not really rcN material, so
> > > > I'd appreciate if you could queue it to your for-mfd branch instead.
> > > 
> > > The last two:
> > > 
> > >   mfd: ab8500-sysctrl: Set sysctrl_dev during probe
> > This one is already in mfd-fixes, the commit log was clear enough.
> 
> Great!
> 
> > >   mfd: ab8500-sysctrl: Let sysctrl driver work without pdata
> > This one is not, as the commit log is not showing it actually fixes something
> > but only makes the code cleaner. If it really fixes something, could you
> > please provide me with a commit log that describes what exactly it fixes ?
> 
> Ok, the fix here is that right now that driver is initialized without a
> specific pdata (that is plat->sysctrl), so enforcing it breaks existing
> platforms for no reason.  To make the commit more clear I would just
> point that out as in (just last two sentences):
> 
> --- >8 ---
> mfd: ab8500-sysctrl: Let sysctrl driver work without pdata
> 
> A check for a valid plat->sysctrl was introduced in:
> 
> 2377e52 mfd: ab8500-sysctrl: Error check clean up
> 
> but the driver works just fine even without that initialization data,
> and enforcing it breaks existing platforms for no reason.
> 
> This patch removes the check and let the driver go ahead with probe.
> --- >8 ---
> 
> Is it better?
Slightly. Next time please describe how it breaks.
I applied and pushed this patch now, I'll send a pull request to Linus
tomorrow morning.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/