linux-kernel - Re: function call fw_iso_resource_mange(..) (core-iso.c) does not return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51145028d1c880d68e0a88d863faa71c@gatzka.org>
Date:	Wed, 22 May 2013 10:59:19 +0200
From:	Stephan Gatzka <stephan.gatzka@...il.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Tejun Heo <tj@...nel.org>, Peter Hurley <peter@...leysoftware.com>,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: function call fw_iso_resource_mange(..) (core-iso.c) does not return


> A third (fourth?) way to fix it --- feasible or not --- would be to 
> break
> the dependency between the worklets.  In this case, use a timer to 
> cancel
> outbound transactions if the request-transmit IRQ event was not 
> received
> before a timeout.  We had such a timeout in the older ieee1394 drivers 
> and
> we also had it in earlier versions of the firewire drivers, at a risk 
> of a
> race between CPU and OHCI.

Why do we need a timer? If we guarantee that bus_reset_work() always 
make progress (if we put it into its own queue), it should always be 
able to complete the corresponding completion object the other works are 
waiting for.

Regards,

Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/