linux-kernel - Re: [PATCH 00/19] driver:usb&net: add missing platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 May 2013 09:30:11 +0800
From:	Gu Zheng <guz.fnst@...fujitsu.com>
To:	Libo Chen <clbchenlibo.chen@...wei.com>
CC:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	David Miller <davem@...emloft.net>, libo.chen@...wei.com,
	gregkh@...uxfoundation.org, samuel@...tiz.org,
	stern@...land.harvard.edu, khc@...waw.pl,
	akpm@...ux-foundation.org, balbi@...com,
	sarah.a.sharp@...ux.intel.com, alexander.shishkin@...ux.intel.com,
	brudley@...adcom.com, linux-usb@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	lizefan@...wei.com
Subject: Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

On 05/21/2013 05:42 PM, Libo Chen wrote:

> On 2013/5/21 17:06, Thomas Petazzoni wrote:
>> Dear Gu Zheng,
>>
>> On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote:
>>
>>>> Or, maybe make the existing module_platform_driver() macro do this?
>>>
>>> But not all the modules use module_platform_driver() macro to replace the module init/exit.
>>
>> Then maybe it's a good opportunity to convert those ones to use
>> module_platform_driver() ?
>>
>> Thomas
>>
> 
>  In my opinion, not all modules can use module_platform_driver() macro to replace the module init/exit easily, like us3mc_init.
> 
>  Furthermore this work will touch various platforms and architectures, I am worried it is hard to *test* (compile and boot).

Agree. I stick to the way that David mentioned.

Thanks,
Gu

> 
>  What do you think?
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/