linux-kernel - Re: [PATCH 2/5] powerpc, perf: Enable conditional branch filter for POWER8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 May 2013 20:20:24 +1000
From:	Michael Neuling <mikey@...ling.org>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	michael@...erman.id.au, eranian@...gle.com, ak@...ux.intel.com,
	mingo@...nel.org
Subject: Re: [PATCH 2/5] powerpc, perf: Enable conditional branch filter for POWER8

Peter Zijlstra <peterz@...radead.org> wrote:

> On Wed, May 22, 2013 at 11:52:38AM +0530, Anshuman Khandual wrote:
> > Enables conditional branch filter support for POWER8
> > utilizing MMCRA register based filter and also invalidates
> > a BHRB branch filter combination involving conditional
> > branches.
> > 
> > Signed-off-by: Anshuman Khandual <khandual@...ux.vnet.ibm.com>
> > ---
> >  arch/powerpc/perf/power8-pmu.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c
> > index 8ed323d..e60b38f 100644
> > --- a/arch/powerpc/perf/power8-pmu.c
> > +++ b/arch/powerpc/perf/power8-pmu.c
> > @@ -548,11 +548,21 @@ static u64 power8_bhrb_filter_map(u64 branch_sample_type)
> >  	if (branch_sample_type & PERF_SAMPLE_BRANCH_IND_CALL)
> >  		return -1;
> >  
> > +	/* Invalid branch filter combination - HW does not support */
> > +	if ((branch_sample_type & PERF_SAMPLE_BRANCH_ANY_CALL) &&
> > +			(branch_sample_type & PERF_SAMPLE_BRANCH_COND))
> > +		return -1;
> > +
> >  	if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY_CALL) {
> >  		pmu_bhrb_filter |= POWER8_MMCRA_IFM1;
> >  		return pmu_bhrb_filter;
> >  	}
> >  
> > +	if (branch_sample_type & PERF_SAMPLE_BRANCH_COND) {
> > +		pmu_bhrb_filter |= POWER8_MMCRA_IFM3;
> > +		return pmu_bhrb_filter;
> > +	}
> > +
> >  	/* Every thing else is unsupported */
> >  	return -1;
> >  }
> 
> So I suppose you've seen what x86 does in this case? ;-) I'm not saying
> you _have_ to do the software filter, but I would like the changelog to at
> least mention the issue.
> 
> In fact, I suppose that should have been in the original patches :/ as
> this patch series only adds the conditional branch support. 

Anshuman,

Now we have the branch reading and parsing code (for the "to" case), we
should use that to do what Peter is suggesting.  

Mikey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/