linux-kernel - Re: [RFC PATCH 02/02] swapon: add "cluster-discard" support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49hahvqfz1.fsf@segfault.boston.devel.redhat.com>
Date:	Wed, 22 May 2013 09:52:34 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
Cc:	Rafael Aquini <aquini@...hat.com>, Karel Zak <kzak@...hat.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	akpm@...ux-foundation.org, hughd@...gle.com, shli@...nel.org,
	riel@...hat.com, lwoodman@...hat.com, mgorman@...e.de
Subject: Re: [RFC PATCH 02/02] swapon: add "cluster-discard" support

KOSAKI Motohiro <kosaki.motohiro@...il.com> writes:

>> Instead of reverting and renaming --discard, what about making it accept an
>> optional argument, so we could use --discard (to enable all thing and keep
>> backward compatibility); --discard=cluster & --discard=batch (or whatever we
>> think it should be named). I'll try to sort this approach out if you folks think
>> it's worthwhile. 
>
> Optional argument looks nice, at least to me. 
>
> But hmm.. 
>
> "cluster" and "batch" describes current kernel implementation, not user visible effect. 
> Usually I suggest to pick up a word from man pages because it describe user visible action.
> e.g. --discard=freed-pages or --discard=io or --discard=swapon or --discard=once, etc..
>
> But this is not strong opinion. You can ignore it. I don't think I have good English sense. :-)

I like discard=swapon.  For the fine-grained discards, I don't have a
strong opinion, but I guess I'd lean towards freed-pages.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/