[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20130522151401.E69EDE0090@blue.fi.intel.com>
Date: Wed, 22 May 2013 18:14:01 +0300 (EEST)
From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To: Hillf Danton <dhillf@...il.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
Andrea Arcangeli <aarcange@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Al Viro <viro@...iv.linux.org.uk>,
Hugh Dickins <hughd@...gle.com>,
Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>,
Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
Andi Kleen <ak@...ux.intel.com>,
Matthew Wilcox <matthew.r.wilcox@...el.com>,
"Kirill A. Shutemov" <kirill@...temov.name>,
Dave Hansen <dave@...1.net>, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 33/39] thp, mm: implement do_huge_linear_fault()
Hillf Danton wrote:
> On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov
> <kirill.shutemov@...ux.intel.com> wrote:
> > @@ -3316,17 +3361,25 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma,
> > if (unlikely(anon_vma_prepare(vma)))
> > return VM_FAULT_OOM;
> >
> > - cow_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, address);
> > + cow_page = alloc_fault_page_vma(vma, address, flags);
> > if (!cow_page)
> > - return VM_FAULT_OOM;
> > + return VM_FAULT_OOM | VM_FAULT_FALLBACK;
> >
>
> Fallback makes sense with !thp ?
No, it's nop. handle_pte_fault() will notice only VM_FAULT_OOM. That's
what we need.
--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists