linux-kernel - Re: [PATCH 2/2] nouveau: replace large udelay by mdelay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519D25AC.3030804@gmail.com>
Date:	Wed, 22 May 2013 13:08:12 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Marc Dietrich <marvin24@....de>
CC:	linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
	Ben Skeggs <bskeggs@...hat.com>
Subject: Re: [PATCH 2/2] nouveau: replace large udelay by mdelay

On 05/22/2013 12:48 PM, Marc Dietrich wrote:
> ARM has a maximum of 2000 usec delay. Use mdelay for larger delays.
> This affects distro kernels mostly.
>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Ben Skeggs <bskeggs@...hat.com>
> Signed-off-by: Marc Dietrich <marvin24@....de>
> ---
>   drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c b/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> index d0817d9..ed7415e 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> @@ -51,7 +51,8 @@ nv50_dac_sense(struct nv50_disp_priv *priv, int or, u32 loadval)
>   	const u32 doff = (or * 0x800);
>   	int load = -EINVAL;
>   	nv_wr32(priv, 0x61a00c + doff, 0x00100000 | loadval);
> -	udelay(9500);
> +	mdelay(9);
> +	udelay(500);

That looks very ugly.  Can you just use 9 or 10 instead of adding on the 
extra 500uS?

David Daney

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/