linux-kernel - Re: [PATCH 01/14] do_mounts: constify name_to_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130522134812.40924cb34eaea1588b756a14@linux-foundation.org>
Date:	Wed, 22 May 2013 13:48:12 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joern Engel <joern@...fs.org>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	Borislav Petkov <bp@...en8.de>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 01/14] do_mounts: constify name_to_dev_t parameter

On Thu,  9 May 2013 16:42:57 -0400 Joern Engel <joern@...fs.org> wrote:

> --- a/include/linux/mount.h
> +++ b/include/linux/mount.h
> @@ -74,6 +74,6 @@ extern struct vfsmount *vfs_kern_mount(struct file_system_type *type,
>  extern void mnt_set_expiry(struct vfsmount *mnt, struct list_head *expiry_list);
>  extern void mark_mounts_for_expiry(struct list_head *mounts);
>  
> -extern dev_t name_to_dev_t(char *name);
> +extern dev_t name_to_dev_t(const char *name);
>  
>  #endif /* _LINUX_MOUNT_H */
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index 1d1b634..da96f85 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -202,7 +202,7 @@ done:
>   *	bangs.
>   */
>  
> -dev_t name_to_dev_t(char *name)
> +dev_t name_to_dev_t(const char *name)
>  {
>  	char s[32];
>  	char *p;

A changelog would be nice.  There are 1.1 billion places in the kernel
where we could make such a change - why was this one made?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/