linux-kernel - Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 May 2013 16:57:04 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Kent Yoder <shpedoikal@...il.com>
Cc:	leosilva@...ux.vnet.ibm.com, adlai@...ux.vnet.ibm.com,
	Daniel De Graaf <dgdegra@...ho.nsa.gov>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	TPM Device Driver List <tpmdd-devel@...ts.sourceforge.net>,
	Ian.Campbell@...rix.com, Jan Beulich <JBeulich@...e.com>,
	xen-devel@...ts.xen.org
Subject: Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote:
> >> +     notify_remote_via_evtchn(priv->evtchn);
> >> +
> >> +     ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
> >
> > Um, + 6? Why? Is there an #define for that magic constant?
> > Should this value be read before you do the wait_for_tpm_stat stuff?
> 
>   This is hardcoded to 6 even in tpm.c.  Time for a #define...
> 
> > Otherwise it looks OK to me. Should this go through me or Kent?
> > And if so, is Kent waiting for my feedback?
> 
>   My comments were minor -- I was expecting feedback on your earlier
> comments before merging.  I think this should go through the tpmdd
> maintainer if its going to live in drivers/char/tpm though.

That is you I thought?

konrad@...nom:~/mm$ scripts/get_maintainer.pl -f drivers/char/tpm
Kent Yoder <key@...ux.vnet.ibm.com> (maintainer:TPM DEVICE DRIVER)
Rajiv Andrade <mail@...jiv.net> (maintainer:TPM DEVICE DRIVER)
Marcel Selhorst <tpmdd@...horst.net> (maintainer:TPM DEVICE DRIVER)
Sirrix AG <tpmdd@...rix.com> (maintainer:TPM DEVICE DRIVER)
tpmdd-devel@...ts.sourceforge.net (moderated list:TPM DEVICE DRIVER)
linux-kernel@...r.kernel.org (open list)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/