linux-kernel - Re: [PATCH] drivers: iio: adc: convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <519D36C2.5000009@kernel.org>
Date:	Wed, 22 May 2013 22:21:06 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Silviu-Mihai Popescu <silviupopescu1990@...il.com>
CC:	linux-iio@...r.kernel.org, Jonathan Cameron <jic23@....ac.uk>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: iio: adc: convert to devm_ioremap_resource()

On 05/11/2013 12:06 PM, Silviu-Mihai Popescu wrote:
> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
> 
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@...il.com>
Patch number 3 doing the same thing.  I was somewhat tardy applying
the first one so sorry for wasting your time on this.

Jonathan
> ---
>  drivers/iio/adc/exynos_adc.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 9f3a8ef..22d034a 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -270,16 +270,16 @@ static int exynos_adc_probe(struct platform_device *pdev)
>  	info = iio_priv(indio_dev);
>  
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	info->regs = devm_request_and_ioremap(&pdev->dev, mem);
> -	if (!info->regs) {
> -		ret = -ENOMEM;
> +	info->regs = devm_ioremap_resource(&pdev->dev, mem);
> +	if (IS_ERR(info->regs)) {
> +		ret = PTR_ERR(info->regs);
>  		goto err_iio;
>  	}
>  
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	info->enable_reg = devm_request_and_ioremap(&pdev->dev, mem);
> -	if (!info->enable_reg) {
> -		ret = -ENOMEM;
> +	info->enable_reg = devm_ioremap_resource(&pdev->dev, mem);
> +	if (IS_ERR(info->enable_reg)) {
> +		ret = PTR_ERR(info->enable_reg);
>  		goto err_iio;
>  	}
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/