[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACVXFVPgLiFPSyLi48fa=RbyOantEu-jRynuuZFJ_4Lt5OSXYQ@mail.gmail.com>
Date: Wed, 22 May 2013 12:34:05 +0800
From: Ming Lei <tom.leiming@...il.com>
To: "zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [ANNOUNCE] ktap 0.1 released
On Wed, May 22, 2013 at 12:19 PM, Ming Lei <tom.leiming@...il.com> wrote:
> On Wed, May 22, 2013 at 12:15 PM, Ming Lei <tom.leiming@...il.com> wrote:
>> On Tue, May 21, 2013 at 11:56 AM, zhangwei(Jovi)
>>
>> Nice job, I have run it on ARM already with only one line change.
>>
>> But looks 'Control-C' can't stop the tracing or need some time to complete it,
>> see below:
>
> Sometimes, it doesn't work:
>
> $ sudo ./ktap ./scripts/kretprobe.kp
> ......
> vfs_read! (execname sshd); retval:38
> ^Cvfs_read! (execname sshd); retval:38
>
> probe ending
> vfs_read! (execname sshd); retval:48
> vfs_read! (execname sshd); retval:2
> ^C
> ^C^C^C
> ^C^C^C^C^C^C^C
>
> ^C^C^C^C^C^C
This one can be fixed by below patch, but can't work on
the last one.
diff --git a/vm.c b/vm.c
index c5f5733..a24a389 100644
--- a/vm.c
+++ b/vm.c
@@ -1060,7 +1060,7 @@ ktap_State *kp_newthread(ktap_State *mainthread)
void kp_user_complete(ktap_State *ks)
{
- if (!ks || !G(ks)->user_completion)
+ if (!ks || !G(ks) || !G(ks)->user_completion)
return;
complete(G(ks)->user_completion);
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists