linux-kernel - Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 May 2013 09:32:30 -0500
From:	Jason Hrycay <jhrycay@...il.com>
To:	Namjae Jeon <linkinjeon@...il.com>
CC:	jaegeuk.kim@...sung.com, Amit Sahrawat <a.sahrawat@...sung.com>,
	Namjae Jeon <namjae.jeon@...sung.com>,
	linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, jason.hrycay@...orola.com
Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread

On 5/23/2013 8:58 AM, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@...sung.com>
> 
> when there is an error from kthread_run, then return proper error
> rather than returning -ENOMEM.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@...sung.com>
> ---
>  fs/f2fs/gc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 25b083c..03d5ba1 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -105,7 +105,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi)
>  	if (IS_ERR(gc_th->f2fs_gc_task)) {
>  		kfree(gc_th);

gc_th is free'd here, save off PTR_ERR result to avoid use-after-free?

>  		sbi->gc_thread = NULL;
> -		return -ENOMEM;
> +		return PTR_ERR(gc_th->f2fs_gc_task);
>  	}
>  	return 0;
>  }
> 

--
Jason Hrycay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/