linux-kernel - Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130523160128.GA7660@sirena.org.uk>
Date:	Thu, 23 May 2013 11:01:28 -0500
From:	Mark Brown <broonie@...nel.org>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Davide Ciminaghi <ciminaghi@...dd.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different
 contexts

On Thu, May 23, 2013 at 09:42:37AM -0600, Stephen Warren wrote:

> I guess the core of the issue is that you want to replace spin_lock()
> with spin_lock_irqsave(). I'd like to see that explicitly described in
> the commit description, if that is the core aspect of this change.

Yes, I was just going to rewrite the commit log to make this a lot
clearer - the entire first paragraph could pretty much just be replaced
by just saying that we need spin_lock_irqsave() to allow interaction
with interrupt context.

> ... and obviously add a spinlock_flags field to struct regmap (perhaps
> start unioning the mutex and spinlock data fields there if you want to
> save space).

This should work, yes - care to respin Lars-Peter?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)