linux-kernel - Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130523161059.GC7660@sirena.org.uk>
Date:	Thu, 23 May 2013 11:10:59 -0500
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Davide Ciminaghi <ciminaghi@...dd.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different
 contexts

On Thu, May 23, 2013 at 05:50:15PM +0200, Lars-Peter Clausen wrote:
> On 05/23/2013 05:42 PM, Stephen Warren wrote:

> > I guess the core of the issue is that you want to replace spin_lock()
> > with spin_lock_irqsave(). I'd like to see that explicitly described in
> > the commit description, if that is the core aspect of this change.

> Hm, it does.

> 	regmap-mmio uses a spinlock with spin_lock() and spin_unlock() for
> 	locking.
> 	...
> 	This patch updates the adds a flags parameter to the regmap lock
> 	and unlock callbacks and uses spin_lock_irqsave() and
> 	spin_unlock_restore() ...

That's pretty buried in the changelog though - really all the first
paragraph needs to say is that we want to use the irqsave versions to
allow interaction with interrupt context.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)