linux-kernel - Re: [I2C] informations + advice about messages handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130524142017.52545a52@endymion.delvare>
Date:	Fri, 24 May 2013 14:20:17 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	"Mylene Josserand" <Mylene.Josserand@...ocap.com>
Cc:	"anish singh" <anish198519851985@...il.com>,
	"kernelnewbies" <kernelnewbies@...nelnewbies.org>,
	"Linux I2C" <linux-i2c@...r.kernel.org>,
	"linux-kernel-mail" <linux-kernel@...r.kernel.org>,
	"Arnd Bergmann" <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [I2C] informations + advice about messages handling

On Fri, 24 May 2013 11:52:54 +0200, Mylene Josserand wrote:
> Right now, my company uses the "i2c_smbus_read/write_byte_data" 
> functions to talk to devices through an application. On the datasheet of 
> these devices, I search but did not seem to be SMBus compliant.
> As it was a software which was using these functions, we thought that a 
> driver (that I would write) should be better. And here I am ! I prefer 
> to understand well the mechanism before coding anything and it is 
> interesting !

If the application was using i2c_smbus_read/write_byte_data from
user-space, then a kernel driver would call the same functions. No
reason why this wouldn't work.

> (...)
> Thanks for the explanation.
> No problem, we have 2 devices used without drivers :
> - an odometer PIC18F24201 : In the datasheet, there is a SMBus select 
> bit but I don't know if it is SMBus compliant.

Couldn't find the datasheet for this one, unfortunately.

> - an audio codec tlv320aic3204 : There is a driver for this device but 
> for some reasons, we did not use it. Did not find a "SMBus compliant" in 
> its datasheet.

The tlv320aic32x4 driver uses i2c_master_send, which is a shortcut to
i2c_transfer. However it seems to only send 2 bytes on the bus at once,
the same could be achieved with i2c_smbus_write_byte_data if needed.

For completeness: a device might use transactions which are compliant
with SMBus without being formally "SMBus-compliant", because SMBus has
more constraints than just transaction types (I kept things simple
originally to not confuse you.) This may explain why it isn't mentioned
in the datasheet. Or just because the manufacturer did not care because
they target fully I2C-capable systems anyway.

What you have to look at is the transaction types. They are usually
described in the datasheet. Then compare with either the SMBus
specification or
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/i2c/smbus-protocol
and if they match then you can use the i2c_smbus_*() calls.

> (...)
> Thanks a lot for your help !

You're welcome.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/