linux-kernel - Re: [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 May 2013 09:53:07 -0300
From:	Emilio López <emilio@...pez.com.ar>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	davem@...emloft.net, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stefan Roese <sr@...x.de>,
	Florian Fainelli <florian@...nwrt.org>,
	kevin@...winnertech.com, sunny@...winnertech.com,
	shuge@...winnertech.com
Subject: Re: [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support
 in dts

Hi,

El 24/05/13 06:23, Maxime Ripard escribió:
> From: Stefan Roese <sr@...x.de>
> 
> Signed-off-by: Stefan Roese <sr@...x.de>
> ---
>  arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> index b70fe0d..32d9b18 100644
> --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> @@ -27,6 +27,21 @@
>  	};
>  
>  	soc@...20000 {
> +		emac: ethernet@...0b000 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&emac_pins_a>;
> +			phy = <&phy0>;
> +			status = "okay";
> +		};
> +
> +		mdio@...0b080 {
> +			status = "okay";
> +
> +			phy0: ethernet-phy@0 {
> +				reg = <0>;
> +			};

During my testing I found out that I needed to use 1 as reg for the
driver to work. You can find a fixup patch enclosed that changes this;
it's possible that some extra changes may also be needed (s/phy0/phy1/
on the node?)

Cheers,

Emilio

View attachment "fixup-reg.patch" of type "text/x-diff" (712 bytes)