linux-kernel - Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519F7C2E.2060409@cogentembedded.com>
Date:	Fri, 24 May 2013 18:41:50 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"B, Ravi" <ravibabu@...com>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Balbi, Felipe" <balbi@...com>
Subject: Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register
 APIs from glue

Hello.

On 24-05-2013 9:34, B, Ravi wrote:

>>>> removed unused nop xceiv (un_)register API's from all musb platform
>>>> drivers

>>>      Since when are they unused?

>> Please refer to commit id 662dca54 : usb: otg: support for multiple transceivers by a single controller.
>> Usb_get_phy() is used to get the of phy used by controller, phy bindings are done through DT.

>>     Why are you sure that all these platforms support DT (in all configurations)?
>> It seems to me that you're simply breaking the patched glue layers with this patch.
>> I'll let Felipe decide the fate of this patch though...

> You are correct, the bindings of phy and controller need not to done through DT alone, there is a saperate API
> Phy API's available for such bindings done in respective board platform files.

    I don't see any such code in e.g. DaVinci/DA8xx platform files.

>>>> Signed-off-by: Ravi Babu <ravibabu@...com>
>> --
>> Ravi B

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/