lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 May 2013 07:59:07 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Jingoo Han <jg1.han@...sung.com> Cc: 'Andrew Morton' <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, 'Wim Van Sebroeck' <wim@...ana.be>, linux-watchdog@...r.kernel.org Subject: Re: [PATCH 3/5] watchdog: da9055: use platform_{get,set}_drvdata() On Thu, May 23, 2013 at 07:44:23PM +0900, Jingoo Han wrote: > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han <jg1.han@...sung.com> Reviewed-by: Guenter Roeck <linux@...ck-us.net> > --- > drivers/watchdog/da9055_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.c > index f5ad105..575f37a 100644 > --- a/drivers/watchdog/da9055_wdt.c > +++ b/drivers/watchdog/da9055_wdt.c > @@ -174,7 +174,7 @@ static int da9055_wdt_probe(struct platform_device *pdev) > goto err; > } > > - dev_set_drvdata(&pdev->dev, driver_data); > + platform_set_drvdata(pdev, driver_data); > > ret = watchdog_register_device(&driver_data->wdt); > if (ret != 0) > @@ -187,7 +187,7 @@ err: > > static int da9055_wdt_remove(struct platform_device *pdev) > { > - struct da9055_wdt_data *driver_data = dev_get_drvdata(&pdev->dev); > + struct da9055_wdt_data *driver_data = platform_get_drvdata(pdev); > > watchdog_unregister_device(&driver_data->wdt); > kref_put(&driver_data->kref, da9055_wdt_release_resources); > -- > 1.7.10.4 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists