linux-kernel - Re: [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130524201539.GB17847@lukather>
Date:	Fri, 24 May 2013 22:15:39 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Emilio López <emilio@...pez.com.ar>
Cc:	davem@...emloft.net, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stefan Roese <sr@...x.de>,
	Florian Fainelli <florian@...nwrt.org>,
	kevin@...winnertech.com, sunny@...winnertech.com,
	shuge@...winnertech.com
Subject: Re: [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in
 dts

Hi Emilio,

On Fri, May 24, 2013 at 09:53:07AM -0300, Emilio López wrote:
> Hi,
> 
> El 24/05/13 06:23, Maxime Ripard escribió:
> > From: Stefan Roese <sr@...x.de>
> > 
> > Signed-off-by: Stefan Roese <sr@...x.de>
> > ---
> >  arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> > index b70fe0d..32d9b18 100644
> > --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> > +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
> > @@ -27,6 +27,21 @@
> >  	};
> >  
> >  	soc@...20000 {
> > +		emac: ethernet@...0b000 {
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&emac_pins_a>;
> > +			phy = <&phy0>;
> > +			status = "okay";
> > +		};
> > +
> > +		mdio@...0b080 {
> > +			status = "okay";
> > +
> > +			phy0: ethernet-phy@0 {
> > +				reg = <0>;
> > +			};
> 
> During my testing I found out that I needed to use 1 as reg for the
> driver to work. You can find a fixup patch enclosed that changes this;
> it's possible that some extra changes may also be needed (s/phy0/phy1/
> on the node?)

Merged, thanks for noticing!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/