linux-kernel - Re: [RESEND PATCH] pwm: pwm-atmel-tcb: pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519F21BA.6040403@overkiz.com>
Date:	Fri, 24 May 2013 10:15:54 +0200
From:	boris brezillon <b.brezillon@...rkiz.com>
To:	Thierry Reding <thierry.reding@...onic-design.de>
CC:	linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [RESEND PATCH] pwm: pwm-atmel-tcb: pinctrl support

On 23/05/2013 21:35, Thierry Reding wrote:
> On Thu, May 23, 2013 at 06:38:52PM +0200, Boris BREZILLON wrote:
>> Hello,
>>
>> I sent a patch 1 month ago to add pinctrl support to pwm-atmel-tcb
>> driver and didn't get any review.
>>
>> Could you take a look?
>>
>> This patch adds pins request for the pwm device exposed by the TC
>> block using the pinctrl subsystem.
> I was actually looking at this a few days back and thought I remembered
> this being handled in the core now. There was some discussion about this
> back in January (?) as far as I remember. I just verified that indeed
> there is code in the driver core code to do this. See commit:
>
> 	ab78029ecc347debbd737f06688d788bd9d60c1d  drivers/pinctrl: grab default handles from device core
>
> Are you sure this is really necessary in the driver?
No.

Thanks for pointing this commit out (I didn't notice the default handles 
were grabbed
from device core).

I'll test it without this patch.

Best Regards,
Boris
> Thierry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/