linux-kernel - Re: [RFC PATCH v2, part 2 14/18] PCI, EDAC: use hotplug-safe PCI bus iterators to walk PCI buses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 25 May 2013 23:18:59 +0800
From:	Liu Jiang <liuj97@...il.com>
To:	Gu Zheng <guz.fnst@...fujitsu.com>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Jiang Liu <jiang.liu@...wei.com>,
	"Rafael J . Wysocki" <rjw@...k.pl>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Toshi Kani <toshi.kani@...com>,
	Myron Stowe <myron.stowe@...hat.com>,
	Yijing Wang <wangyijing@...wei.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	linux-edac@...r.kernel.org
Subject: Re: [RFC PATCH v2, part 2 14/18] PCI, EDAC: use hotplug-safe PCI
 bus iterators to walk PCI buses

On Wed 22 May 2013 12:12:19 PM CST, Gu Zheng wrote:
> On 05/15/2013 12:51 AM, Jiang Liu wrote:
>
>> Enhance EDAC drviers to use hotplug-safe iterators to walk PCI buses.
>>
>> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>
>> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
>> Cc: Doug Thompson <dougthompson@...ssion.com>
>> Cc: linux-edac@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> ---
>>   drivers/edac/i7core_edac.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
>> index 0ec3e95..39d5823 100644
>> --- a/drivers/edac/i7core_edac.c
>> +++ b/drivers/edac/i7core_edac.c
>> @@ -1296,7 +1296,7 @@ static unsigned i7core_pci_lastbus(void)
>>   	int last_bus = 0, bus;
>>   	struct pci_bus *b = NULL;
>>
>> -	while ((b = pci_find_next_bus(b)) != NULL) {
>> +	for_each_pci_root_bus(b)
>
> missing the "{":
> +	for_each_pci_root_bus(b) {
Hi Zheng,
             Thanks for review! Will fix it in next version.
Regards!
Gerry

>
>>   		bus = b->number;
>>   		edac_dbg(0, "Found bus %d\n", bus);
>>   		if (bus > last_bus)
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/