[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d36f8c1a-dca0-41d2-a478-7c1551844b42@email.android.com>
Date: Sat, 25 May 2013 00:11:33 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Zhang Yanfei <zhangyanfei.yes@...il.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Vivek Goyal <vgoyal@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Simon Horman <horms@...ge.net.au>
CC: "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/7] Remove unused /dev/oldmem interface
Awesome!
Zhang Yanfei <zhangyanfei.yes@...il.com> wrote:
>/dev/oldmem provides the interface for us to access the "old memory" in
>the dump-capture kernel. Unfortunately, no one actually uses this
>interface.
>
>And this interface could actually cause some real problems if used on
>ia64
>where the cached/uncached accesses are mixed. See the discussion from
>the link: https://lkml.org/lkml/2013/4/12/386.
>
>So Eric suggested that we should remove /dev/oldmem as an unused piece
>of
>code.
>
>Besides, we used a global variable saved_max_pfn to let the capture
>kernel
>know the amount of memory that the previous kernel used. And for almost
>all
>architectures (except x86. In x86, saved_max_pfn is used by
>detect_calgary()),
>the only user of this variable is the read_oldmem interface of
>/dev/oldmem, so
>also remove the setting for saved_max_pfn in those architectures.
>
>Zhang Yanfei (7):
> /dev/oldmem: Remove this interface
> Documentation/devices.txt: Remove /dev/oldmem description
> Documentation/kdump/kdump.txt: Remove /dev/oldmem description
> mips: Remove savemaxmem parameter setup
> powerpc: Remove savemaxmem parameter setup
> ia64: Remove setting for saved_max_pfn
> s390: Remove setting for saved_max_pfn
>
> Documentation/devices.txt | 2 -
> Documentation/kdump/kdump.txt | 31 +++++--------------------
> arch/ia64/kernel/efi.c | 5 ----
> arch/mips/kernel/crash_dump.c | 10 --------
> arch/powerpc/kernel/crash_dump.c | 10 --------
> arch/s390/kernel/setup.c | 4 ---
>drivers/char/mem.c | 47
>--------------------------------------
> 7 files changed, 6 insertions(+), 103 deletions(-)
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists