linux-kernel - Re: [PATCH] kernel/auditfilter.c: fix compiler warning about decimal constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 25 May 2013 16:31:08 +0200
From:	richard -rw- weinberger <richard.weinberger@...il.com>
To:	Toralf Förster <toralf.foerster@....de>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/auditfilter.c: fix compiler warning about decimal constant

On Sat, May 25, 2013 at 11:12 AM, Toralf Förster <toralf.foerster@....de> wrote:
> fixes
>
>   CC      kernel/auditfilter.o
>   kernel/auditfilter.c: In function ‘audit_data_to_entry’:
>   kernel/auditfilter.c:426:3: warning: this decimal constant is unsigned
>   only in ISO C90 [enabled by default]
>
> Signed-off-by: Toralf Förster <toralf.foerster@....de>
> ---
>  kernel/auditfilter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 6bd4a90..0ee9eff 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
>                 f->lsm_rule = NULL;
>
>                 /* Support legacy tests for a valid loginuid */
> -               if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
> +               if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295U)) {

Why not UINT_MAX?

>                         f->type = AUDIT_LOGINUID_SET;
>                         f->val = 0;
>                 }
> --
> 1.8.1.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/