linux-kernel - Re: [PATCH v3 2/9] media: davinci: vpif: Convert to devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51A21E0D.2030509@cogentembedded.com>
Date:	Sun, 26 May 2013 18:37:01 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Prabhakar Lad <prabhakar.csengg@...il.com>
CC:	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	LMML <linux-media@...r.kernel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/9] media: davinci: vpif: Convert to devm_* api

Hello.

On 26-05-2013 16:00, Prabhakar Lad wrote:

> From: Lad, Prabhakar <prabhakar.csengg@...il.com>

> Use devm_ioremap_resource instead of reques_mem_region()/ioremap().
> This ensures more consistent error values and simplifies error paths.

> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
>   drivers/media/platform/davinci/vpif.c |   27 ++++-----------------------
>   1 files changed, 4 insertions(+), 23 deletions(-)

> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> index 761c825..f857d8f 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
[...]
> @@ -421,23 +419,12 @@ EXPORT_SYMBOL(vpif_channel_getfid);
>
>   static int vpif_probe(struct platform_device *pdev)
>   {
> -	int status = 0;
> +	static struct resource	*res;
>
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
[...]
> +	vpif_base = devm_request_and_ioremap(&pdev->dev, res);

    No, don't use this deprecated funtion please. Undo to 
devm_ioremap_resource().

> +	if (IS_ERR(vpif_base))

     NAK, devm_request_and_ioremap() doesn't rethrn error cpdes, only 
NULL. BTW, it's implemented via a call to devm_ioremap_resource() now.
Is it so hard to look at the code that you've calling?

> +		return PTR_ERR(vpif_base);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/