linux-kernel - Re: [PATCH v2 3/5] media: davinci: vpif: remove unnecessary braces around defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9072131.neW5PtBrWa@avalon>
Date:	Sun, 26 May 2013 02:51:27 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Prabhakar Lad <prabhakar.csengg@...il.com>
Cc:	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	LMML <linux-media@...r.kernel.org>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] media: davinci: vpif: remove unnecessary braces around defines

Hi Prabhakar,

Thank you for the patch.

On Saturday 25 May 2013 22:06:34 Prabhakar Lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@...il.com>
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> ---
>  drivers/media/platform/davinci/vpif.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/davinci/vpif.c
> b/drivers/media/platform/davinci/vpif.c index 164c1b7..d9269c9 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -32,10 +32,10 @@
>  MODULE_DESCRIPTION("TI DaVinci Video Port Interface driver");
>  MODULE_LICENSE("GPL");
> 
> -#define VPIF_CH0_MAX_MODES	(22)
> -#define VPIF_CH1_MAX_MODES	(02)
> -#define VPIF_CH2_MAX_MODES	(15)
> -#define VPIF_CH3_MAX_MODES	(02)
> +#define VPIF_CH0_MAX_MODES	22
> +#define VPIF_CH1_MAX_MODES	02
> +#define VPIF_CH2_MAX_MODES	15
> +#define VPIF_CH3_MAX_MODES	02

Could you also replace 02 with 2 while you're at it ? 02 is an octal constant. 
While it still evaluates to 2 in this case, it would be a good practice to use 
decimal when decimal is intended.

With that change,

Laurent Pinchart <laurent.pinchart@...asonboard.com>

>  spinlock_t vpif_lock;
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/