linux-kernel - Re: [PATCH 22/24] drivers/media/radio/radio-maxiradio: Convert to module_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201305271132.57946.hverkuil@xs4all.nl>
Date:	Mon, 27 May 2013 11:32:57 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Libo Chen <libo.chen@...wei.com>
Cc:	mchehab@...hat.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, lizefan@...wei.com,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH 22/24] drivers/media/radio/radio-maxiradio: Convert to module_pci_driver

On Mon 27 May 2013 04:31:59 Libo Chen wrote:
> use module_pci_driver instead of init/exit, make code clean
> 
> Signed-off-by: Libo Chen <libo.chen@...wei.com>

Acked-by: Hans Verkuil <hans.verkuil@...co.com>

> ---
>  drivers/media/radio/radio-maxiradio.c |   13 +------------
>  1 files changed, 1 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/media/radio/radio-maxiradio.c b/drivers/media/radio/radio-maxiradio.c
> index bd4d3a7..1d1c9e1 100644
> --- a/drivers/media/radio/radio-maxiradio.c
> +++ b/drivers/media/radio/radio-maxiradio.c
> @@ -200,15 +200,4 @@ static struct pci_driver maxiradio_driver = {
>  	.remove		= maxiradio_remove,
>  };
>  
> -static int __init maxiradio_init(void)
> -{
> -	return pci_register_driver(&maxiradio_driver);
> -}
> -
> -static void __exit maxiradio_exit(void)
> -{
> -	pci_unregister_driver(&maxiradio_driver);
> -}
> -
> -module_init(maxiradio_init);
> -module_exit(maxiradio_exit);
> +module_pci_driver(maxiradio_driver);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/