linux-kernel - Re: [PATCH] arch: blackfin: kernel: using strlcpy instead of strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51A2BC00.2050906@asianux.com>
Date:	Mon, 27 May 2013 09:50:56 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Mike Frysinger <vapier@...too.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	realmz paranoid <realmz6@...il.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>, monstr@...str.eu,
	"uclinux-dist-devel@...ckfin.uclinux.org" 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH] arch: blackfin: kernel: using strlcpy instead of strncpy

On 05/26/2013 03:04 PM, Chen Gang wrote:
> 
> For NULL terminated string, need always be sure of ended by zero.
> 
> 'command_line' is a static variable which will be initialized
> automatically, and cmdline_init() is __init function, so need not
> initialize it again, can just use strlcpy instead of strncpy.
> 

The 2nd paragraph comment is redundent, need delete. I will send patch v2.

> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  arch/blackfin/kernel/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
> index 107b306..c731ec7 100644
> --- a/arch/blackfin/kernel/setup.c
> +++ b/arch/blackfin/kernel/setup.c
> @@ -1458,5 +1458,5 @@ void __init cmdline_init(const char *r0)
>  {
>  	early_shadow_stamp();
>  	if (r0)
> -		strncpy(command_line, r0, COMMAND_LINE_SIZE);
> +		strlcpy(command_line, r0, COMMAND_LINE_SIZE);
>  }
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/