| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <51A36D42.6080609@linaro.org> Date: Mon, 27 May 2013 16:27:14 +0200 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Baruch Siach <baruch@...s.co.il> CC: John Stultz <john.stultz@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH] clocksource: dw_apb: fix error check On 05/27/2013 03:49 PM, Baruch Siach wrote: > Hi Daniel, > > On Mon, May 27, 2013 at 03:14:23PM +0200, Daniel Lezcano wrote: >> On 05/27/2013 01:51 PM, Baruch Siach wrote: >>> irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ. >>> This breaks on platforms that have NO_IRQ != 0. >>> >>> Cc: <stable@...r.kernel.org> >>> Signed-off-by: Baruch Siach <baruch@...s.co.il> >>> --- >> >> Shouldn't the 'irq_of_parse_and_map' function to be fixed and return >> NO_IRQ in case of error ? (even if some code checks the return value is >> 'zero' in case of error [1], while some other code checks NO_IRQ [2]). > > Probably not. See http://lwn.net/Articles/470820/. Very interesting. Thx for the pointer ! -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists