linux-kernel - Re: [PATCH 1/1] rtc: rtc-ds1307: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHdPZaNptkbUEWHKm_YWbfNgyJZwNfisGKSHHwm8BuBe+g42pQ@mail.gmail.com>
Date:	Mon, 27 May 2013 09:51:51 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Nikolay Balandin <nbalandin@....rtsoft.ru>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] rtc: rtc-ds1307: use devm_*() functions

On Mon, May 27, 2013 at 6:32 AM, Jingoo Han <jg1.han@...sung.com> wrote:
> On Saturday, May 25, 2013 10:51 AM, Devendra Naga wrote:
>> On Sat, May 25, 2013 at 10:41 AM, Nikolay Balandin wrote:
>> > From: Nikolay Balandin <nbalandin@....rtsoft.ru>
>
> [.....]
>
>> >
>> > -       ds1307->rtc = rtc_device_register(client->name, &client->dev,
>> > +       ds1307->rtc = devm_rtc_device_register(&client->dev, client->name,
>> >                                 &ds13xx_rtc_ops, THIS_MODULE);
>
> Hi Nikolay Baladin, Devendra Naga,
>
> Here, "devm"_rtc_device_register() is used.
> Thus, rtc_device_unregister() will be called after remove() or
> on probe failure.
>

You are correct, I am not aware of the new API that is added  by you
in c100a5e0255.

Very sorry Nikolay Baladin, I would really have seen and commented on the patch.

Thanks for letting me know. :)


>
>> >         if (IS_ERR(ds1307->rtc)) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/