linux-kernel - Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51A2FB88.9000303@nvidia.com>
Date:	Mon, 27 May 2013 11:52:00 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
CC:	Kishon Vijay Abraham I <kishon@...com>,
	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	"balbi@...com" <balbi@...com>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"broonie@...nel.org" <broonie@...nel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"george.cherian@...com" <george.cherian@...com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>
Subject: Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote:
> On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote:
>>> Hi Kishon,
>>>
>>> I have some comment about this patch
>>> and upload modified patch to following repository (extcon-for-palmas).
>>> - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmas&id=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c
>>>
>>> This patchset include patch related to other module
>>> ,so I need your opinion to apply this patchset to git repository.
>> yeah.. Still there is some confusion with palmas_set_switch_smps10(). I think we can remove it for now and add it separately later. By this at least we can have device mode fully functional in OMAP5. What do you think?
>>
>   I agree your opinion.
>
> But, I propose some fixes about palmas_set_switch_smps10().
> I dont' prefer to call global function in exton-palmas.c from palmas-regulator.c.
> So, Why don't you use regulator consumer instead of global function?
> You can register specific regulator for enabling or disabling SMPS10_SWITCH_EN
> and then control SMPS10_SWITCH_EN bit through regulator framework in extcon-palmas.c
> without calling global function.

Along with this, I also like to make the VBUS regulator control to be 
optional here. Currently it is mandatory.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/