linux-kernel - Re: [PATCH] power_supply: generic-adc-battery: Fix checking if none of the channels are supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7N6vr9Jynd0ezXTRb8spGtxAKsRnrYGOtgTiYMPDDz_u1vMA@mail.gmail.com>
Date:	Tue, 28 May 2013 11:57:37 +0530
From:	anish singh <anish198519851985@...il.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	linux-kernel-mail <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power_supply: generic-adc-battery: Fix checking if none
 of the channels are supported

On Fri, May 24, 2013 at 11:11 PM, Axel Lin <axel.lin@...ics.com> wrote:
> If none of the channels are supported, index is 0.
> Also ensure to return error code instead of 0 in goto second_mem_fail path.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
Acked-by: anish kumar <anish198519851985@...il.com>

I think anton would have already picked up.
> ---
>  drivers/power/generic-adc-battery.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/generic-adc-battery.c b/drivers/power/generic-adc-battery.c
> index 8cb5d7f..59a1421 100644
> --- a/drivers/power/generic-adc-battery.c
> +++ b/drivers/power/generic-adc-battery.c
> @@ -299,8 +299,10 @@ static int gab_probe(struct platform_device *pdev)
>         }
>
>         /* none of the channels are supported so let's bail out */
> -       if (index == ARRAY_SIZE(gab_chan_name))
> +       if (index == 0) {
> +               ret = -ENODEV;
>                 goto second_mem_fail;
> +       }
>
>         /*
>          * Total number of properties is equal to static properties
> --
> 1.8.1.2
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/