linux-kernel - Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130528084833.GA30172@gmail.com>
Date:	Tue, 28 May 2013 10:48:33 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>,
	Pekka Enberg <penberg@...nel.org>
Subject: Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also


* Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:

> Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu:
> > From: Namhyung Kim <namhyung.kim@....com>
> > 
> > Add a new column for showing callchain overhead.  I feel like it's
> > more natural than having those overhead next to a first child in a
> > same column.
> 
> Callchains in GTK, great! Some observations tho:
> 
> All those leaves with 0.00% looks ugly/not needed, right?
> 
> I took a screenshot and put at:
> 
> http://vger.kernel.org/~acme/perf-gtk-callchains.png

Looks really nice!

I'm wondering, would it be hard to add alternating lightgrey+white 
background colors to make the entries striped and for the horizontal 
structure to thus stand out better?

The 'qgit' tool does that for example, to alternate git commit log 
entries.

(Extra points for striping only where the line actually begins.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/