linux-kernel - Re: [PATCH] regulator: 88pm800: add regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130528142040.GI3660@sirena.org.uk>
Date:	Tue, 28 May 2013 10:20:40 -0400
From:	Mark Brown <broonie@...nel.org>
To:	Chao Xie <cxie4@...vell.com>
Cc:	yi zhang <yizhang.mrvl@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"jett.zhou@...vell.com" <jett.zhou@...vell.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yi Zhang <yizhang@...vell.com>
Subject: Re: [PATCH] regulator: 88pm800: add regulator driver

On Tue, May 28, 2013 at 05:10:00AM -0700, Chao Xie wrote:

Please fix your mail client to word wrap within paragraphs.

> Thanks for your review.
> Because structure regulator_desc only accepts the voltage table as constant.
> struct regulator_desc {
> 	...
> 	const unsigned int *volt_table;
> 	...
> };
> If we want to make use of the volt_table, and the help functions regulator_map_voltage_iterate and regulator_list_voltage_table, we have to initialize the tables as what we do now.

If you are calculating this stuff you shouldn't be providing a voltage
table at all.  The whole point is that these things shouldn't be using
voltage tables.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)