linux-kernel - Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfXZMZvw_XmPKEWcBikbx7pk1oHoxa0ztoQ1ywhi5Ovew@mail.gmail.com>
Date:	Tue, 28 May 2013 18:29:58 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Libo Chen <clbchenlibo.chen@...wei.com>
Cc:	dwmw2@...radead.org, zajec5@...il.com,
	artem.bityutskiy@...ux.intel.com,
	Bill Pemberton <wfp5p@...ginia.edu>, hauke@...ke-m.de,
	linux-mtd@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

This is good fix, but I rather prefer not to see it in this shape.
See comments below.

On Wed, May 22, 2013 at 6:51 AM, Libo Chen <clbchenlibo.chen@...wei.com> wrote:
>
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash  not its member.
>
> Signed-off-by: Libo Chen <libo.chen@...wei.com>
> Acked-by: Rafał Miłecki <zajec5@...il.com>
> ---
>  drivers/mtd/devices/bcm47xxsflash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> * add Acked-by: Rafał Miłecki <zajec5@...il.com>
> * change send list
>
> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
> index 9526628..4aa9141 100644
> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
>         return 0;
>
>  err_dev_reg:
> -       kfree(&b47s->mtd);
> +       kfree(b47s);
>  out:
>         return err;
>  }

What about to switch to devm_* and remove those labels and kfrees at all?

Additionally you can add another patch to use module_platform_driver()
macro instead of module_init/exit.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/