linux-kernel - Re: [PATCH] 9p: trace: use %*ph to dump buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 May 2013 13:09:42 -0500
From:	Rob Landley <rob@...dley.net>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org, v9fs-developer@...ts.sourceforge.net,
	Eric Van Hensbergen <ericvh@...il.com>
Subject: Re: [PATCH] 9p: trace: use %*ph to dump buffer

On 05/28/2013 03:49:52 AM, Andy Shevchenko wrote:
> On Mon, 2013-04-22 at 16:01 +0300, Andy Shevchenko wrote:
> > Additionally change cast from long to unsigned long to follow  
> specificator.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  include/trace/events/9p.h | 28 +++-------------------------
> >  1 file changed, 3 insertions(+), 25 deletions(-)
> >
> > diff --git a/include/trace/events/9p.h b/include/trace/events/9p.h
> > index beeaed8..a066636 100644
> > --- a/include/trace/events/9p.h
> > +++ b/include/trace/events/9p.h
> > @@ -143,31 +143,9 @@ TRACE_EVENT(9p_protocol_dump,
> >  		    __entry->tag    =  pdu->tag;
> >  		    memcpy(__entry->line, pdu->sdata, P9_PROTO_DUMP_SZ);
> >  		    ),
> > -	    TP_printk("clnt %lu %s(tag = %d)\n%.3x: "
> > -		      "%02x %02x %02x %02x %02x %02x %02x %02x "
> > -		      "%02x %02x %02x %02x %02x %02x %02x %02x\n"
> > -		      "%.3x: "
> > -		      "%02x %02x %02x %02x %02x %02x %02x %02x "
> > -		      "%02x %02x %02x %02x %02x %02x %02x %02x\n",
> > -		      (long)__entry->clnt, show_9p_op(__entry->type),
> > -		      __entry->tag, 0,
> > -		      __entry->line[0],  __entry->line[1],
> > -		      __entry->line[2],  __entry->line[3],
> > -		      __entry->line[4],  __entry->line[5],
> > -		      __entry->line[6],  __entry->line[7],
> > -		      __entry->line[8],  __entry->line[9],
> > -		      __entry->line[10], __entry->line[11],
> > -		      __entry->line[12], __entry->line[13],
> > -		      __entry->line[14], __entry->line[15],
> > -		      16,
> > -		      __entry->line[16], __entry->line[17],
> > -		      __entry->line[18], __entry->line[19],
> > -		      __entry->line[20], __entry->line[21],
> > -		      __entry->line[22], __entry->line[23],
> > -		      __entry->line[24], __entry->line[25],
> > -		      __entry->line[26], __entry->line[27],
> > -		      __entry->line[28], __entry->line[29],
> > -		      __entry->line[30], __entry->line[31])
> > +	    TP_printk("clnt %lu %s(tag = %d)\n%.3x: %16ph\n%.3x:  
> %16ph\n",
> > +		      (unsigned long)__entry->clnt,  
> show_9p_op(__entry->type),
> > +		      __entry->tag, 0, __entry->line, 16, __entry->line  
> + 16)
> >   );
> >
> >  #endif /* _TRACE_9P_H */
> 
> Any comment on this one, anyone?

While we're at it, here's a patch adding the rest of the 9p files to  
the maintainers entry, in hopes that Erich and the list get pinged on  
this stuff in future.

Rob
View attachment "9p.patch" of type "text/x-patch" (527 bytes)