linux-kernel - Re: [PATCH v3] drivers/tpm: add xen tpmfront interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130528203216.GA25602@phenom.dumpdata.com>
Date:	Tue, 28 May 2013 16:32:16 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Daniel De Graaf <dgdegra@...ho.nsa.gov>
Cc:	linux-kernel@...r.kernel.org, tpmdd-devel@...ts.sourceforge.net,
	xen-devel@...ts.xen.org, mail@...jiv.net, tpmdd@...horst.net,
	tpmdd@...rix.com, leosilva@...ux.vnet.ibm.com,
	adlai@...ux.vnet.ibm.com, shpedoikal@...il.com
Subject: Re: [PATCH v3] drivers/tpm: add xen tpmfront interface

On Tue, May 28, 2013 at 11:40:32AM -0400, Daniel De Graaf wrote:
> This is a complete rewrite of the Xen TPM frontend driver, taking
> advantage of a simplified frontend/backend interface and adding support
> for cancellation and timeouts.  The backend for this driver is provided
> by a vTPM stub domain using the interface in Xen 4.3.
> 
> Signed-off-by: Daniel De Graaf <dgdegra@...ho.nsa.gov>
> Acked-by: Matthew Fioravante <matthew.fioravante@...apl.edu>

.. snip..
> +static void ring_free(struct tpm_private *priv)
> +{
> +	if (!priv)
> +		return;
> +
> +	if (priv->ring_ref)
> +		gnttab_end_foreign_access(priv->ring_ref, 0,
> +				(unsigned long)priv->shr);
> +	else
> +		free_page((unsigned long)priv->shr);
> +
> +	if (priv->chip && priv->chip->vendor.irq)
> +		unbind_from_irqhandler(priv->chip->vendor.irq, priv);

You are missing:

	if (priv->evtchn != INVALID_EVTCHN)
		xenbus_free_evtchn(priv->xdev, priv->evtchn);

> +
> +	kfree(priv);
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/