lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 May 2013 00:22:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jasowang@...hat.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, mst@...hat.com Subject: Re: [PATCH] tuntap: forbid changing mq flag for persistent device From: Jason Wang <jasowang@...hat.com> Date: Wed, 29 May 2013 12:32:11 +0800 > We currently allow changing the mq flag (IFF_MULTI_QUEUE) for a persistent > device. This will result a mismatch between the number the queues in netdev and > tuntap. This is because we only allocate a 1q netdevice when IFF_MULTI_QUEUE was > not specified, so when we set the IFF_MULTI_QUEUE and try to attach more queues > later, netif_set_real_num_tx_queues() may fail which result a single queue > netdevice with multiple sockets attached. > > Solve this by disallowing changing the mq flag for persistent device. > > Bug was introduced by commit edfb6a148ce62e5e19354a1dcd9a34e00815c2a1 > (tuntap: reduce memory using of queues). > > Reported-by: Sriram Narasimhan <sriram.narasimhan@...com> > Cc: Michael S. Tsirkin <mst@...hat.com> > Signed-off-by: Jason Wang <jasowang@...hat.com> Applied, thanks Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists