linux-kernel - Re: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock when the system time changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 May 2013 08:47:32 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"David Vrabel" <david.vrabel@...rix.com>
Cc:	"John Stultz" <john.stultz@...aro.org>, <xen-devel@...ts.xen.org>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock when
 the system time changes

>>> On 28.05.13 at 20:22, David Vrabel <david.vrabel@...rix.com> wrote:
> @@ -199,28 +201,59 @@ static void xen_get_wallclock(struct timespec *now)
>  
>  static int xen_set_wallclock(const struct timespec *now)
>  {
> -	struct xen_platform_op op;
> -	int ret;
> -
>  	/* do nothing for domU */
>  	if (!xen_initial_domain())
>  		return -1;
>  
> -	/* Set the Xen wallclock. */
> +	/* Set the hardware RTC. */
> +	return mach_set_rtc_mmss(now);
> +
> +}

Can't you achieve the same effect in a cleaner way by overriding
x86_platform.set_wallclock only in the non-init-domain case?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/