linux-kernel - Re: [tip:irq/core] irq/x86/io_apic: Fix number of pre-allocated irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130529091950.GB25621@gmail.com>
Date:	Wed, 29 May 2013 11:19:50 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	hpa@...or.com, linux-kernel@...r.kernel.org,
	david.a.cohen@...el.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:irq/core] irq/x86/io_apic: Fix number of pre-allocated irqs


* Thomas Gleixner <tglx@...utronix.de> wrote:

> On Tue, 28 May 2013, tip-bot for David Cohen wrote:
> 
> > Commit-ID:  8c956b1b935ec98decb470a6abff8c1f8b28e9f0
> > Gitweb:     http://git.kernel.org/tip/8c956b1b935ec98decb470a6abff8c1f8b28e9f0
> > Author:     David Cohen <david.a.cohen@...el.com>
> > AuthorDate: Tue, 30 Apr 2013 16:20:15 -0700
> > Committer:  Ingo Molnar <mingo@...nel.org>
> > CommitDate: Tue, 28 May 2013 12:01:29 +0200
> > 
> > irq/x86/io_apic: Fix number of pre-allocated irqs
> > 
> > arch_probe_nr_irqs() has a typo when returning number of
> > preallocated irqs. Instead of returning the calculated value, it
> > returns a constant number NR_IRQ_LEGACY.
> 
> That's not a typo. That's on purpose.
> 
> We don't want to allocate a gazillion of interrupt descriptors for
> nothing. The only ones which must be pre-allocated are the legacy
> ones.
> 
> > This patch makes sure the calculated value is returned intead.
> 
> And therefor defeats the whole purpose of sparse irqs.
> 
> I'll zap that commit.

Oops, I had a sneaking suspicion about this change but did not read the 
code far enough - thanks for correcting my brainfart!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/