linux-kernel - [PATCH] arch: blackfin: kernel: memory overflow, 'namebuf' length need be more than 256

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 May 2013 18:07:02 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Mike Frysinger <vapier@...too.org>, anton.vorontsov@...aro.org,
	Richard Kuo <rkuo@...eaurora.org>, jesper.nilsson@...s.com
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	"uclinux-dist-devel@...ckfin.uclinux.org" 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>
Subject: [PATCH] arch: blackfin: kernel: memory overflow, 'namebuf' length
 need be more than 256


The 'name' length in decode_address() may be 255, after call d_path()
successfully.

So for decode_address(), the input 'buf' need be more than 256, or may
memory overflow.

For simply thinking of, use 'namebuf[512]' instead of 'namebuf[150]'
which will pass to decode_address() as input 'buf'.

Also better use macro instead of hard code number when processing
symbols work.


Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
 arch/blackfin/kernel/trace.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/kernel/trace.c b/arch/blackfin/kernel/trace.c
index c36efa0..4fecd3e 100644
--- a/arch/blackfin/kernel/trace.c
+++ b/arch/blackfin/kernel/trace.c
@@ -37,7 +37,7 @@ void decode_address(char *buf, unsigned long address)
 	const char *symname;
 	char *modname;
 	char *delim = ":";
-	char namebuf[128];
+	char namebuf[KSYM_NAME_LEN];
 #endif
 
 	buf += sprintf(buf, "<0x%08lx> ", address);
@@ -845,7 +845,7 @@ void dump_bfin_mem(struct pt_regs *fp)
 
 void show_regs(struct pt_regs *fp)
 {
-	char buf[150];
+	char buf[512];
 	struct irqaction *action;
 	unsigned int i;
 	unsigned long flags = 0;
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/