linux-kernel - Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130529124357.GA15210@redhat.com>
Date:	Wed, 29 May 2013 13:43:57 +0100
From:	"Richard W.M. Jones" <rjones@...hat.com>
To:	Kent Overstreet <koverstreet@...gle.com>
Cc:	Jens Axboe <axboe@...nel.dk>,
	Calvin Owens <jcalvinowens@...il.com>,
	linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
	NeilBrown <neilb@...e.de>, majianpeng@...il.com
Subject: Re: [PATCH] md: Partially revert 2f6db2a7, which broke raid5


On Sun, May 19, 2013 at 10:51:45AM -0700, Kent Overstreet wrote:
> Sorry for the delay - been vacationing. Reproduced the original bug,
> here's a patch that fixes it:
> 
> 
> commit 402f5db3708b2062795a384a3d8397cf702e27bc
> Author: Kent Overstreet <koverstreet@...gle.com>
> Date:   Sun May 19 10:27:07 2013 -0700
> 
>     raid5: Initialize bi_vcnt
>     
>     The patch that converted raid5 to use bio_reset() forgot to initialize
>     bi_vcnt.
>     
>     Signed-off-by: Kent Overstreet <koverstreet@...gle.com>
>     Cc: NeilBrown <neilb@...e.de>
>     Cc: Jens Axboe <axboe@...nel.dk>
>     Cc: linux-raid@...r.kernel.org
> 
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 9359828..753f318 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -664,6 +664,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
>  			if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
>  				bi->bi_rw |= REQ_FLUSH;
>  
> +			bi->bi_vcnt = 1;
>  			bi->bi_io_vec[0].bv_len = STRIPE_SIZE;
>  			bi->bi_io_vec[0].bv_offset = 0;
>  			bi->bi_size = STRIPE_SIZE;
> @@ -701,6 +702,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
>  			else
>  				rbi->bi_sector = (sh->sector
>  						  + rrdev->data_offset);
> +			rbi->bi_vcnt = 1;
>  			rbi->bi_io_vec[0].bv_len = STRIPE_SIZE;
>  			rbi->bi_io_vec[0].bv_offset = 0;
>  			rbi->bi_size = STRIPE_SIZE;

Ditto to the previous follow up.  We've been tracking this
bug for nearly a month:

https://bugzilla.redhat.com/show_bug.cgi?id=962079

Please include this (or the other) patch to fix it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/