linux-kernel - Re: [PATCH v2 9/9] gpio-tz1090-pdc: add TZ1090 PDC gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ0Gav0TKDXyD9MwaUrdcenV=+JV9oWNN1+ifsbO3uJ1w@mail.gmail.com>
Date:	Wed, 29 May 2013 17:38:48 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	James Hogan <james.hogan@...tec.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH v2 9/9] gpio-tz1090-pdc: add TZ1090 PDC gpio driver

On Fri, May 24, 2013 at 6:21 PM, James Hogan <james.hogan@...tec.com> wrote:

> Add a GPIO driver for the low-power Powerdown Controller GPIOs in the
> TZ1090 SoC.
(...)
> +  Values for gpio specifier:
> +  - GPIO number: a value in the range 0 to 6.
> +  - GPIO flags: bit field of flags:
> +      1: active low

Use #include <dt-bindings/gpio/gpio.h>
for flags and symbolic names.

> +Optional properties:
> +- gpio-ranges: Mapping to pin controller pins
> +
> +- interrupts: Individual syswake interrupts (other GPIOs cannot interrupt)
> +
> +
> +Example:
> +
> +       pdc_gpios: gpio-controller@...06500 {
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +
> +               compatible = "img,tz1090-pdc-gpio";
> +               reg = <0x02006500 0x100>;
> +
> +               interrupt-parent = <&pdc>;
> +               interrupts =    <1 0 0>,        /* Syswake 0 */
> +                               <1 1 0>,        /* Syswake 1 */
> +                               <1 2 0>;        /* Syswake 2 */
> +       };

Interrupt flags seem to be undocumented here.

Apart from this it's looking nice.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/